This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] for PR 17531

From: Paolo Bonzini <bonzini at gnu dot org>
To: Zdenek Dvorak <rakdver at atrey dot karlin dot mff dot cuni dot cz>
Cc: dje at watson dot ibm dot com, gcc-patches at gcc dot gnu dot org
Date: Mon, 27 Sep 2004 10:10:15 +0200
Subject: Re: [patch] for PR 17531
References: <20040923121639.GB6592@atrey.karlin.mff.cuni.cz> <200409231430.i8NEUFV34074@makai.watson.ibm.com> <20040923180251.GB19335@atrey.karlin.mff.cuni.cz> <20040923204014.GF8766@redhat.com> <20040923210357.GA11304@atrey.karlin.mff.cuni.cz>

Not really.  expand_binop does not assume that its operands have the
same type as result, so the patch would be a proper fix for the function
anyway.

Then the same thing should be done in expand_twoval_binop and prepare_cmp_insn, or the bug would stay latent there. Assuming it is the right fix, of course.

Paolo

References:
- [patch] for PR 17531
  - From: Zdenek Dvorak
- Re: [patch] for PR 17531
  - From: David Edelsohn
- Re: [patch] for PR 17531
  - From: Zdenek Dvorak
- Re: [patch] for PR 17531
  - From: Richard Henderson
- Re: [patch] for PR 17531
  - From: Zdenek Dvorak

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]