This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH]: Fix PR 17587
On Thu, 2004-09-23 at 10:53 -0700, Richard Henderson wrote:
> On Wed, Sep 22, 2004 at 10:35:00AM -0400, Daniel Berlin wrote:
> > Luckily, however, we don't actually need to see the insertions we've made,
> > since we know we'll make them. Thus, the easiest way to fix this bug is
> > to simply not commit edge inserts until the end of PRE, when we don't care
> > if we create a new basic block or not.
>
> Does that mean it's not worthwhile to split critical edges too?
We could probably get away with it, but splitting critical edges can
expose additional redundancies, just because of CFG structure, that we
wouldn't see otherwise.
At least, this was the case last time I looked at this.
I can rerun tests to see if this is true if you like.
>
>
> r~
--