This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: More commentary for libcpp/charset.c
- From: "Joseph S. Myers" <jsm at polyomino dot org dot uk>
- To: Zack Weinberg <zack at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sat, 18 Sep 2004 20:00:43 +0000 (UTC)
- Subject: Re: More commentary for libcpp/charset.c
- References: <87sm9gpf7y.fsf@codesourcery.com>
On Fri, 17 Sep 2004, Zack Weinberg wrote:
> As requested by Joseph Myers. Bootstrapped amd64-linux, Just To Be Sure.
>
> zw
>
> * charset.c (_cpp_destroy_iconv, emit_numeric_escape)
> (_cpp_convert_input, _cpp_default_encoding): Add comments.
> Some other comments in this file also tweaked.
Thanks. I should probably file a PR for the original problem
> + /* Note: this code does not handle the case where the target
> + and host have a different number of bits in a byte. */
that led to noticing the missing comments so that anyone wanting to make
C4x work properly in this regard and searching for bugs with c4x listed as
target is aware of the problem. (The existing bugs for C4x target suggest
it has been rather more seriously broken - not building libgcc or trivial
programs - for some time, and I suspect the rather specialised uses of C4x
processors don't generally involve string constants.)
--
Joseph S. Myers http://www.srcf.ucam.org/~jsm28/gcc/
http://www.srcf.ucam.org/~jsm28/gcc/#c90status - status of C90 for GCC 4.0
jsm@polyomino.org.uk (personal mail)
jsm28@gcc.gnu.org (Bugzilla assignments and CCs)