This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: profile.c USE_MAPPED_LOCATION support


Hi -

hubicka wrote:

> [...]
> > ! 		  /* ??? source_locus type is marked deprecated in input.h.  */
> > ! 		  source_locus curr_location = bb->succ->goto_locus;
> > ! 		  /* ??? The FILE/LINE API is inconsistent for these cases.  */
> 
> This means that the goto_locus construct is completely broken by
> USE_MAPPED_LOCATION?   [...]

I don't think so, just that the USE_MAPPED_LOCATION and the
!USE_MAPPED_LOCATION macros in <input.h> are not compatible for
processing source_locus values directly.  I believe the proposed
code works for both by specifying suitable macro calls for each
configuration.  Can you suggest some specific test (other than
bprob.exp which already ran) to confirm functionality?

- FChE

Attachment: pgp00000.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]