This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Add two ObjC++ callback functions to cp/decl.c
On 10 Sep 2004, at 16.07, Mark Mitchell wrote:
Ziemowit Laski wrote:
The patches are occurring in _files_ _belonging_ to the C++
front-end. They affect the C++ front-end only if they prevent the
file(s) in question from compiling.
That's true at runtime, but not at edit time. They affect me because
there is now more code that I have to look through when trying to
understand how things work and more code to change when modifying
things.
Mark, you've just described all changes made to all parts of the
compiler. :-)
I can't simply ignore the code if I need to modify things; in some
cases, your code might not even compile after I make a change.
Indeed; ditto. Can't ignore code. No good.
The SC specifically made Objective-C++ a second-class citizen. So,
I'm unsympathetic to your counter-argument that changes to the C++
front end might affect Objective-C++. That was explicitly part of the
deal.
Fair enough; but by the same token, if the proverbial ObjC++ fragments
suddenly stop compiling, you can just '#if 0' them out and tell me to
fix them.
Arguing that changes to files in cp/ don't need to be reviewed by a
C++ maintainer, after you've been asked to send those patches for
review, seems pretty aggressive.
It suppose it would have been "aggressive," had I actually made such an
argument... Anyway, rock beats scissors, so I'll send all future cp/
mods to the list for review. :-)
Good weekend to all,
--Zem