This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [rfa] one-liner in lex.c
- From: Eric Christopher <echristo at redhat dot com>
- To: Michael Snyder <msnyder at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 09 Sep 2004 11:36:48 -0700
- Subject: Re: [rfa] one-liner in lex.c
- References: <002101c49697$e722c460$e51910ac@msnyder8600>
On Thu, 2004-09-09 at 11:07, Michael Snyder wrote:
> Hi folks,
>
> Looks like your patch submission process is fairly similar to gdb's...
>
> Adding this 'else' to the inner loop in _cpp_clean_line seems pretty
> obvious.
> Since it's on the critical path, it might even yield a trivial performance
> win.
As Paul said, there's no performance win here that I can see, but for
clarity the else should probably be there.
For the ChangeLog entry you just want to state what you did, not the
reasoning behind it though. So it should probably read:
2004-09-09 Michael Snyder <msnyder@redhat.com>
* lex.c (_cpp_clean_line): Add 'else' in inner loop.
instead.
Note, I'm not approving this since it's not my area :)
-eric
--
Eric Christopher <echristo@redhat.com>