This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [Java]: Create a new Java-specific ggc-none.c


Hi Zack,

>> Unfortunately, both gcjh and jcf-dump rely on ggc-none.o
>> (cf. java/Make-lang.in) and when build!=host, they end up trying to
>> link in the ggc-none.o built using $(CC_FOR_BUILD), which is
>> incorrect (and sort of freaky, if you think about it).
>>
>> After pondering the possible alternatives, I figured that the least
>> instrusive alternative was to respect the semantics and intended
>> consumption rules of the top-level ggc-none.c and create create a
>> new Java-specific variant which includes config.h rather than
>> bconfig.h. See the comments in ggc-none.c of the following patch for
>> further details.
>
>I am not a Java maintainer.  However, I would prefer one of these two
>alternatives to your patch:
>
>2) Rather than duplicating ggc-none.c from the top level, make it
>   possible to build that for build or host, using GENERATOR_FILE to
>   select bconfig.h/config.h.

Based on your receptiveness towards modifying the top-level ggc-none.c,
I am rescinding this patch and currently testing what I believe to be your
second alternative.

-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/





Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]