This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] [Java]: Create a new Java-specific ggc-none.c
- From: Mohan Embar <gnustuff at thisiscool dot com>
- To: Zack Weinberg <zack at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org
- Date: Mon, 06 Sep 2004 08:49:21 -0500
- Subject: Re: [PATCH] [Java]: Create a new Java-specific ggc-none.c
- Reply-to: gnustuff at thisiscool dot com
Hi Zack,
>> Unfortunately, both gcjh and jcf-dump rely on ggc-none.o
>> (cf. java/Make-lang.in) and when build!=host, they end up trying to
>> link in the ggc-none.o built using $(CC_FOR_BUILD), which is
>> incorrect (and sort of freaky, if you think about it).
>>
>> After pondering the possible alternatives, I figured that the least
>> instrusive alternative was to respect the semantics and intended
>> consumption rules of the top-level ggc-none.c and create create a
>> new Java-specific variant which includes config.h rather than
>> bconfig.h. See the comments in ggc-none.c of the following patch for
>> further details.
>
>I am not a Java maintainer. However, I would prefer one of these two
>alternatives to your patch:
>
>2) Rather than duplicating ggc-none.c from the top level, make it
> possible to build that for build or host, using GENERATOR_FILE to
> select bconfig.h/config.h.
Based on your receptiveness towards modifying the top-level ggc-none.c,
I am rescinding this patch and currently testing what I believe to be your
second alternative.
-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/