This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH]: Remove -DGENERATOR_FILE from rtl.o, bitmap.o targets
- From: Mohan Embar <gnustuff at thisiscool dot com>
- To: Zack Weinberg <zack at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sun, 05 Sep 2004 14:20:53 -0500
- Subject: Re: [PATCH]: Remove -DGENERATOR_FILE from rtl.o, bitmap.o targets
- Reply-to: gnustuff at thisiscool dot com
Hi Zack,
>> The change to rtl.c of this patch:
>>
>> http://gcc.gnu.org/ml/gcc-cvs/2004-08/msg00699.html
>>
>> ...broke my (i686-pc-linux-gnu,i686-pc-linux-gnu,i686-pc-mingw32)
>> build. I don't pretend to know much about this stuff, but
>> defining -DGENERATOR_FILE when the compiler used to build
>> the target is anything other than $(CC_FOR_BUILD) doesn't seem
>> right.
>Your patch appears correct in principle, but I'd like to know what the
>failure is. And I'm not sure what you mean by
>(i686-pc-linux-gnu,i686-pc-linux-gnu,i686-pc-mingw32).
First of all, by (i686-pc-linux-gnu,i686-pc-linux-gnu,i686-pc-mingw32)
I mean the (build,host,target) combination for a given compiler build. In this
particular case, I mean the (cross) compiler built on i686-pc-linux-gnu,
hosted on i686-pc-linux-gnu, which targets i686-pc-mingw32.
As for the failure, rtl.c includes system.h which includes <sys/wait.h>
if HAVS_SYS_WAIT_H is defined. <sys/wait.h> exists on i686-pc-linux-gnu
but not on i686-pc-mingw32. However, -DGENERATOR_FILE causes
rtl.c to incorrectly include bconfig.h (which defines HAVE_SYS_WAIT_H)
instead of config.h (which doesn't), thereby freaking out the build of rtl.o.
Hope that clarifies things a bit.
-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/