This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: #pragma pack fixes (PR c/7054)
- From: "Giovanni Bajo" <rasky at develer dot com>
- To: <JBeulich at novell dot com>
- Cc: "Richard Henderson" <rth at redhat dot com>,<gcc-patches at gcc dot gnu dot org>
- Date: Fri, 3 Sep 2004 20:17:41 +0200
- Subject: Re: #pragma pack fixes (PR c/7054)
- References: <s1190b35.050@emea1-mh.id2.novell.com> <20040903172247.GB12505@redhat.com>
Richard Henderson wrote:
>> PR c/7054
>> * defaults.h (TARGET_DEFAULT_PACK_STRUCT): Provide default.
>> * tree.h (initial_max_fld_align): Declare
>> * stor-layout.c (initial_max_fld_align): Define and initialize.
>> (maximum_field_alignment): Initialize to the same value.
>> * common.opt: Add -fpack-struct= variant of switch.
>> * opts.c: Handle -fpack-struct= variant of switch.
>> * c-pragma.c: Change #pragma pack() handling so that it becomes
>> compatible to other compilers: accept individual 'push' argument,
>> make final pop restore (command line) default, correct interaction
>> of push/pop and sole specification of a new alignment (so that the
>> sequence #pragma pack(push) - #pragma pack(<n>) becomes identical
>> to #pragma pack(push, <n>).
>> * doc/extend.texi: New node "Structure-Packing Pragmas" under
>> "Pragmas", describing #pragma pack.
>> * doc/invoke.texi: Document -fpack-struct=<n> variant of switch.
>> * doc/tm.texi: Adjust description for HANDLE_PRAGMA_PACK_PUSH_POP.
>> Document new TARGET_DEFAULT_PACK_STRUCT.
>>
>> testsuite:
>> 2004-08-10 Jan Beulich <jbeulich@novell.com>
>> * gcc.dg/pack-test-2.c: Adjust to permit and check #pragma pack(push).
>> * gcc.dg/c99-flex-array-4.c: Add -fpack-struct=8 to provide a
>> deterministic starting point for the alignment of structure fields.
>> * gcc.dg/Wpadded.c: Dito.
>> * g++.dg/abi/vbase10.C: Dito.
>
> Applied.
Jan, can you prepare a patch for http://gcc.gnu.org/gcc-3.5/changes.html
describing this change (and also the new NetWare target)?
Thanks,
Giovanni Bajo