This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Lno branch merge part 12 -- induction variable optimizations


On Sat, 28 Aug 2004, Zdenek Dvorak wrote:

> this patch implements the following induction variable optimizations:
> 
> -- strength reduction
> -- induction variable elimination
> -- induction variable merging

But nothing at all amenable to testing in the gcc.dg/tree-ssa framework 
(or otherwise in the testsuite)?  How did you test that each feature of 
this patch works properly and why can't it be tested in the testsuite?

> 5) build_int_cst is rewritten to decide whether to sign extend or to
>    zero extend depending on the signedness of the type of the constant,
>    and to mask out bits outside of the precision, which should be what
>    we want most of the time.  Few places where this is incorrect should
>    use build_int_csts instead.

This sort of interface change surely belongs in a separate patch.

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]