This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Omit frame pointer and fix %ebp by default on x86 (take3)


Roger Sayle wrote:

>> So, why don't you add a runtime sanity check in debug builds so that
>> others won't be fooled by this?
>
> Second thought...  Alternatively, in init_reg_sets_1 we could just
> SET_HARD_REG_BIT (call_used_reg_set, i) whenever fixed_regs[i].  This
> seems slightly friendlier than calling "abort".
>
> Thoughts?  Preferences?

Dunno. I slightly prefer the abort(), since those initializers are provided by
the backend, and we want the backend to stay fixed. Also, if you wade through
regclass.c, you will find several other arrays which may benefit from sanity
checking (for instance call_really_used_regs).

Giovanni Bajo



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]