This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Omit frame pointer and fix %ebp by default on x86 (take 3)


Roger Sayle wrote:

> The second point is that we update both fixed_regs and call_used_regs.
> The cause of the failures mentioned above is caused by the fact that
> reload assumes that call_used_regs is a superset of fixed_regs, and
> so just modifying fixed_regs leads to a few additional testsuite
> failures.

So, why don't you add a runtime sanity check in debug builds so that others
won't be fooled by this?
See also: http://gcc.gnu.org/ml/gcc-patches/2004-06/msg00247.html, which was
submitted after a subtle miscompilation that took weeks to be isolated and
fixed.

Giovanni Bajo



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]