Re: [tree-profiling-branch PATCH] IPA constant propagation

[Andrew Pinski <pinskia at physics dot uc dot edu>]

On Aug 12, 2004, at 12:29 AM, Razya Ladelsky wrote:

> Hello,
> Comments are welcome.
>
> Thanks,
> Razya
>
> Changelog Entry:
>
> 2004-08-12   Razya Ladelsky  <razya@il.ibm.com>
>
>         * ipa_prop.c: New File: IPA constant propagation.
>         * ipa_prop.h: New File: Same.
>         * Makefile.in (ipa_prop.c, ipa_prop.h): Add new files.
>         * common.opt (fipa-cp, fipa-no-cloning): New flags for IPA
> constant
>                 propagation.
>         * cgraphunit.c (cgraph_optimize, record_call_1): Support for 
> IPA
> constant propagation.


One suggestion (and will be a requirement when you submit this to the 
mainline) is to add
comments in front of each function saying what the function does 
including static inline
ones.

Another (someone might also say something about this too) would be I 
hate places where
there are extraneous casts (i.e. ((struct ipa_edge *)cs->aux), maybe 
using an access macro
will help there).