This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Dead code removal in stmt.c
- From: Zack Weinberg <zack at codesourcery dot com>
- To: Paolo Bonzini <bonzini at gnu dot org>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 08 Aug 2004 10:45:47 -0700
- Subject: Re: Dead code removal in stmt.c
- References: <4116294A.40807@gnu.org>
Paolo Bonzini <bonzini@gnu.org> writes:
> This patch eliminates the unnecessary (after I'll commit the expr.c
> patch) stuff in stmt.c to compile ifs, and what remained of the handling
> of block statements. In addition, in order to remove unneeded data
> structures the handling of switch statements is moved entirely to stmt.c
> and into a single function (only slightly bigger than the old
> expand_end_case_type).
>
> Bootstrapped i686-pc-linux-gnu, all languages except Ada; tests
> underway. Ok for mainline if they pass?
OK with one note:
> + /* Make sure case_stmt.start points to something that won't
> + need any transformation before expand_end_case. */
> + if (!NOTE_P (get_last_insn ()))
> + emit_note (NOTE_INSN_DELETED);
> +
> + start = get_last_insn ();
> +
This comment is somewhat inaccurate now that you've smushed all the
case handling together - and is this operation still necessary?
zw