This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [3.3 patch] fix build failure with bash-3.0
Kelley Cook <kcook@gcc.gnu.org> writes:
| >> Needed to build using bash-3.0. Ok to checkin?
| >> 2004-07-30 Matthias Klose <doko@debian.org>
| >> * configure: Add missing 'action' argument to trap.
| >> --- configure~ 2002-09-29 18:11:24.000000000 +0200
| >> +++ configure 2004-07-29 10:39:12.000000000 +0200
| >> @@ -1596,7 +1596,7 @@
| >> # Perform the same cleanup as the trap handler, minus the "exit 1" of course,
| >> # and reset the trap handler.
| >> rm -rf ${tmpdir}
| >> -trap 0
| >> +trap - 0
| >> exit 0
| > I believe
| > trap '' 0
| > is more portable. Also, in the future would you please indicate
| > that a patch is only relevant to 3.3 (or 3.4, or whatever) more
| > explicitly?
| > I missed the annotation in the subject on first read.
|
|
| "trap 0" is present twice within GCC 3.3's configure:
| Line 700 and line 1599, so they both should be corrected.
Indeed. With those corrections, the patch is OK.
Thanks,
-- Gaby