This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Remove DUP_PASS macro


Brian Booth wrote:

> This removes the
> need to manually use the macro DUP_PASS to duplicate optimization
> passes.

Great!

>+  /* Flag indicating whether the pass has already been added to the
>+     pass list. */
>+  unsigned int in_pass_list: 1;

BOOL_BITFIELD maybe?


+  0     /* in_pass_list */

Why do we need this for every pass? Can't we just leave it out the initializer
so that it gets default-initialized to 0? Maybe you can document that it has to
stay at the bottom of the structure.

Giovanni Bajo



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]