This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Cleanup REG_VTABLE_REF, some old warn_notreached tricks
- From: Matthias Klose <doko at cs dot tu-berlin dot de>
- To: Steven Bosscher <steven at lrdcali dot lr dot tudelft dot nl>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sat, 17 Jul 2004 11:23:08 +0200
- Subject: Re: Cleanup REG_VTABLE_REF, some old warn_notreached tricks
- References: <Pine.LNX.4.44.0407160910090.31201-200000@lrdcali.lr.tudelft.nl>
Steven Bosscher writes:
> Hi,
>
> We don't need line notes for warn_notreached, it's handled
> at the tree level now. We also don't have to remove them in
> cfgcleanup.c to avoid an unreachable code warning.
>
> I don't know what REG_VTABLE_REF was for, but it is unused now
> as far as I can tell.
>
> Bootstrapped and tested on i686-unknown-linux-gnu. OK?
>
> Gr.
> Steven
>
>
> * cfgcleanup.c (try_simplify_condjump): Don't remove line
> notes to avoid unreachable code warnings.
> * toplev.c (backend_init): Don't emit line notes for
> unreachable code warnings.
>
> * combine.c (distribute_notes): Don't distribute a
> REG_VTABLE_REF note.
> * final.c (final_scan_insn): Don't handle it.
> * rtl.c (reg_note_name): Remove it.
> * rtl.h (enum reg_node): Dito.
this breaks bootstrap on at least hppa-linux:
cc -c -g -DIN_GCC -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -fno-common -DHAVE_CONFIG_H -I. -I. -I../../src/gcc -I../../src/gcc/. -I../../src/gcc/../include -I../../src/gcc/../libcpp/include -I../../src/gcc/../libbanshee/libcompat -I../../src/gcc/../libbanshee -I../../src/gcc/../libbanshee/points-to ../../src/gcc/final.c -o final.o
../../src/gcc/final.c: In function `final_scan_insn':
../../src/gcc/final.c:2406: error: `note' undeclared (first use in this function)
../../src/gcc/final.c:2406: error: (Each undeclared identifier is reported only once
../../src/gcc/final.c:2406: error: for each function it appears in.)
make[4]: *** [final.o] Error 1