This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch: Java: Fix PR 8618
- From: Per Bothner <per at bothner dot com>
- To: Bryce McKinlay <mckinlay at redhat dot com>
- Cc: java-patches at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Fri, 09 Jul 2004 22:16:47 -0700
- Subject: Re: Patch: Java: Fix PR 8618
- References: <40EF67C7.3030504@redhat.com>
Bryce McKinlay wrote:
This patch fixes several problems with access checks on private,
package-private, and protected members, particularly from inner classes:
- The not_accessible_p() function was set up to always allow access to
anything from an inner class.
- Implicit constructor bodies were not created with the correct line
number info, resulting in the wrong bit of code being printed on error
messages.
- Implicit constructors should inherit access flags from their enclosing
type.
- resolve_qualified_expression_name was passing the wrong "where"
argument to not_accessible_p. This parameter should be the type of the
qualifier, not the type in which the target member was found.
The patch fixes PR java/8618 and gives 21 Jacks XPASSes. I have 1 Jacks
regression (8.1.2-runtime-1), however this existed before my patch - see
PR 16327. That test also fails on gcj 3.3, so I'm not sure why the
failure only recently started showing up in Jacks.
I've build most of RHUG with this patch applied.
OK to commit?
Ok. (I haven't looked at the patch in detail, but I didn't see
anything obviously wrong, and I trust you know what you're doing.)
--
--Per Bothner
per@bothner.com http://per.bothner.com/