This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Lno branch merge -- scalar evolutions analyzer

Zdenek Dvorak wrote:

I think it is worth to replace the pointer accesses with clear
function (or macro) names.



for me it gives *less* information (I don't know what other magic the
accessor function might do without looking it up). But if the general
preference is for the accessor functions, I don't mind.


I think reasonable people can reasonably disagree on this issue.

Sebastian, I'd suggest that you leave this part out of your patch; it's orthogonal to the main thrust of the code, and perhaps worthy of some kind of policy discussion on the mailing list.

--
Mark Mitchell
CodeSourcery, LLC
(916) 791-8304
mark@codesourcery.com

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]