This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gfortran] Fix PR 16161


Steven Bosscher wrote:
> Note...
> 
> +  if (c != '(')
> +    {
> +      gfc_error ("Missing character range in IMPLICIT at %C");
> +      goto bad;
> +    }
> 
> +bad:
> +  gfc_syntax_error (ST_IMPLICIT);
> +
> +  gfc_current_locus = cur_loc;
> +  return MATCH_ERROR;
> +}
> 
> we really shouldn't issue two error messages for the same error here.
> 

I tripped over that myself. We don't. I don't know why :-) I think the
first error message would be better, but I didn't want to change too
much. If you think it's worth it, I will make that goto bad2, and put
bad2 behind the gfc_syntax_error.

- Tobi


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]