This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [gfortran] Fix PR 16161
- From: Tobias Schlüter <tobias dot schlueter at physik dot uni-muenchen dot de>
- To: Steven Bosscher <stevenb at suse dot de>
- Cc: GCC Fortran mailing list <fortran at gcc dot gnu dot org>,patch <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 30 Jun 2004 00:40:05 +0200
- Subject: Re: [gfortran] Fix PR 16161
- References: <40E1D6F4.1060209@physik.uni-muenchen.de> <200406300023.50421.stevenb@suse.de>
Steven Bosscher wrote:
> Note...
>
> + if (c != '(')
> + {
> + gfc_error ("Missing character range in IMPLICIT at %C");
> + goto bad;
> + }
>
> +bad:
> + gfc_syntax_error (ST_IMPLICIT);
> +
> + gfc_current_locus = cur_loc;
> + return MATCH_ERROR;
> +}
>
> we really shouldn't issue two error messages for the same error here.
>
I tripped over that myself. We don't. I don't know why :-) I think the
first error message would be better, but I didn't want to change too
much. If you think it's worth it, I will make that goto bad2, and put
bad2 behind the gfc_syntax_error.
- Tobi