This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Java: Fix PR 15715 - Interface access flags


Tom Tromey wrote:

"Bryce" == Bryce McKinlay <mckinlay@redhat.com> writes:



Bryce> +static int get_classfile_modifiers (tree class)


You need a newline after the `int' here.

Bryce> + int valid_toplevel_class_flags = ACC_PUBLIC | ACC_FINAL | ACC_SUPER | Bryce> + ACC_INTERFACE | ACC_ABSTRACT;

Multi-line expressions need parens around them according to GNU coding
standards.




Thanks. I checked in this fix.

Bryce

--- jcf-write.c 27 Jun 2004 15:30:06 -0000 1.147
+++ jcf-write.c 28 Jun 2004 23:47:04 -0000
@@ -2890,12 +2890,13 @@
/* Get the access flags (modifiers) of a class (TYPE_DECL) to be used in the
access_flags field of the class file header. */


-static int get_classfile_modifiers (tree class)
+static int
+get_classfile_modifiers (tree class)
{
  /* These are the flags which are valid class file modifiers.
     See JVMS2 S4.1.  */
-  int valid_toplevel_class_flags = ACC_PUBLIC | ACC_FINAL | ACC_SUPER |
-                                  ACC_INTERFACE | ACC_ABSTRACT;
+  int valid_toplevel_class_flags = (ACC_PUBLIC | ACC_FINAL | ACC_SUPER |
+                                   ACC_INTERFACE | ACC_ABSTRACT);
  int flags = get_access_flags (class);

/* ACC_SUPER should always be set, except for interfaces. */




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]