This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PR15627] Unnest nested functions in libbanshee
- From: Andrew Pinski <pinskia at physics dot uc dot edu>
- To: giovannibajo at libero dot it (Giovanni Bajo)
- Cc: gcc-patches at gcc dot gnu dot org, dberlin at dberlin dot org (Daniel Berlin)
- Date: Sun, 27 Jun 2004 04:15:06 -0400 (EDT)
- Subject: Re: [PR15627] Unnest nested functions in libbanshee
>
> Hello,
>
> libbanshee is stage 1 material, so we should not be using GNU extensions there.
> This patch manually unnests all the nested functions which prevent Sun CC from
> bootstrapping mainline. I don't know if this is enough as I don't have access
> to a Solaris box, but it is surely a step forward. Since I was at it, I also
> removed other small GNU extensions like 'inline' and C++ comments. I did not
> take care of VLAs yet, as it seems to me that Sun CC supports them (right?).
>
> I generated the diff below with -b to make it readable (as all the nested
> functions are reindented), but of course I will commit with correct
> indentation.
>
> Compiled with "make libbanshee", but untested because there are no tests in the
> GCC tree, and the upstream version is different already. OK for mainline?
You can keep the inline if you include one of the header files, I forgot which one.
But basically it will just define it to be nothing.
Thanks,
Andrew Pinski