This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix one-sized FP arrays returning on MIPS
Eric Botcazou <ebotcazou@act-europe.fr> writes:
>> What's wrong with the patch I sent?
>
> Nothing. But the discrepancy between the Long_Float (double) case and the
> Float (float) case will be weird and pessimize the latter over the former.
But:
(a) The code in calls.c is supposed to handle this case. It really
is a bug that it doesn't. Regardless of what MIPS does, other ABIs
could have this requirement, and the code should deal with it properly.
(b) You wanted a patch that could be applied to 3.4. That means not
changing the ABI. I believe that the callee side does _not_ ICE
on single-element float arrays, so this is definitely an ABI change.
(c) The double case is wrong. Making the float case match it is a
step backwards, not forwards.
(d) As you said yourself, the patch to change the ABI would be a kludge.
I don't see why we should prefer that over a patch that addresses
the ICE directly.
Richard