This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C++] Remove uses of TREE_COMPLEXITY from the C++ front end


On Sun, 13 Jun 2004 23:44:11 -0700, Zack Weinberg <zack@codesourcery.com> wrote:

> Jason Merrill <jason@redhat.com> writes:
>
>>>> I don't see the point in trying to remove C_EXP_ORIGINAL_CODE from the C++
>>>> front end until it's removed from the C front end, too.
>>>
>>> The whole point is to remove it from the C front end eventually.
>>
>> Please remove it from both front ends at the same time.
>
> This is exactly the kind of patch that's best done as a series of
> incremental changes.  I don't see why you are objecting to this method.

I'm not objecting to incremental changes in general; I already approved the
other pieces of the patch.  But C_EXP_ORIGINAL_CODE is used in the same way
by both front ends.  I don't see the point in changing two places in the
C++ front end to use a separate mechanism while the C front end is still
using the old one.  I object to patches that cause the C and C++ front ends
to diverge.  In most cases I have to suck it up because people aren't
interested in doing the necessary work for parallel changes, but in this
case I don't see any good reason for the divergence.

Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]