Re: [patch] adjust make_range

[Jeffrey A Law <law at redhat dot com>]

On Thu, 2004-06-10 at 23:19, Eric Christopher wrote:
> > Sorry, but you're going to have to dig deeper.
> 
> Okie. That code _does_ look overly complicated though...
Agreed.


>  Wanna comment
> it with a "here's what i'm doing here?"
If I really understood it, I would -- I was pretty sure your patch
was incorrect, but I couldn't actually sit down and say why the
code as it is written is correct and why your patch was wrong.

That's the ultimate problem that got me to sit down with the code
and just trace through it in both scenarios.

FWIW, I think the code as it stands is wrong too -- intuition tells
me that we should be passing the current value of in_p rather than
a constant based on whether or not we have a low value for the current
acceptable range.

Kenner originally wrote this code (and spent a good deal of time
debugging it IIRC, so maybe he can explain what's happening and
why the code works the way it does).


Jeff


> 
> Thanks.
> 
> -eric