This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Avoid CVS pipe signal for auto checkout


When an entry is made in the CVS loginfo file to do an auto checkout,
the loginfo entry is still responsible for reading the log message.
If this is not done, and if the auto checkout process exits too
quickly or the log message is long, CVS will get a SIGPIPE error when
it writes out the log message.

The example of auto-checkout in the CVS manual looks like this:

^cyclic-pages		(date; cat; (sleep 2; cd /u/www/local-docs; cvs -q update -d) &) >> $CVSROOT/CVSROOT/updatelog 2>&1

The loginfo file in the binutils repository has this:

^htdocs (cat; /usr/sourceware/bin/auto_checkout /www/sourceware/htdocs/binutils %{sv} >> $CVSROOT/CVSROOT/updatelog 2>&1 &)

In both cases, note the 'cat' to read and discard the log message.
The auto-checkout entries in the gcc loginfo file are missing the
'cat'.  This patch adds them.  Is this OK to check in?  Is there any
ChangeLog file for these files?

Ian

Index: loginfo
===================================================================
RCS file: /cvs/gcc/CVSROOT/loginfo,v
retrieving revision 1.60
diff -u -r1.60 loginfo
--- loginfo	13 Apr 2004 18:39:46 -0000	1.60
+++ loginfo	11 Jun 2004 02:16:30 -0000
@@ -25,9 +25,9 @@
 #DEFAULT (echo ""; id; echo %s; date; cat) >> $CVSROOT/CVSROOT/commitlog
 # or
 #DEFAULT (echo ""; id; echo %{sVv}; date; cat) >> $CVSROOT/CVSROOT/commitlog
-^wwwdocs/bugzilla (QMAILHOST=gcc.gnu.org $CVSROOT/CVSROOT/bugzilla-checkout /www/gcc/bugzilla %{sv} >> $CVSROOT/CVSROOT/updatelog 2>&1 &)
-^wwwdocs/cgi-bin (QMAILHOST=gcc.gnu.org $CVSROOT/CVSROOT/cgibin-checkout /www/gcc/cgi-bin %{sv} >> $CVSROOT/CVSROOT/updatelog 2>&1 &)
-^wwwdocs/htdocs  (QMAILHOST=gcc.gnu.org $CVSROOT/CVSROOT/htdocs-checkout /www/gcc/htdocs %{sv} >> $CVSROOT/CVSROOT/updatelog 2>&1 &)
+^wwwdocs/bugzilla (cat; QMAILHOST=gcc.gnu.org $CVSROOT/CVSROOT/bugzilla-checkout /www/gcc/bugzilla %{sv} >> $CVSROOT/CVSROOT/updatelog 2>&1 &)
+^wwwdocs/cgi-bin (cat; QMAILHOST=gcc.gnu.org $CVSROOT/CVSROOT/cgibin-checkout /www/gcc/cgi-bin %{sv} >> $CVSROOT/CVSROOT/updatelog 2>&1 &)
+^wwwdocs/htdocs  (cat; QMAILHOST=gcc.gnu.org $CVSROOT/CVSROOT/htdocs-checkout /www/gcc/htdocs %{sv} >> $CVSROOT/CVSROOT/updatelog 2>&1 &)
 ^gcc/libstdc..-v3 (QMAILHOST=gcc.gnu.org /usr/sourceware/bin/log_accum_bugzillafied -D gcc.gnu.org -T gcc -G gcc -C gcc -U "http://gcc.gnu.org/cgi-bin/cvsweb.cgi/"; -m libstdc++-cvs@gcc.gnu.org -m gcc-cvs@gcc.gnu.org -s %{sVv})
 
 # Send Java commits to the java-cvs list.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]