Re: Unreviewed Patches for H8/300 : Request for review

[Jeffrey A Law <law at redhat dot com>]

On Tue, 2004-06-08 at 02:52, Anil Paranjape wrote:
> Hi,
> 
> Please find following links of two patches, 
> 
> http://gcc.gnu.org/ml/gcc-patches/2004-06/msg00216.html
> http://gcc.gnu.org/ml/gcc-patches/2004-06/msg00215.html
> 
> Kindly review above two patches for H8/300 target.
These are both fine.  I'll install them into the mainline
momentarily.

Mark -- these should both be safe for the GCC 3.4 branch.  I'll
include the changes as a single patch below to make it easy for you
to apply to the GCC 3.4 branch.

Anil -- from my investigation it appears that the condition for
the ldm_h8300s_4 expander is wrong:

(define_expand "ldm_h8300s_4"
  [(match_operand:SI 0 "register_operand" "")
   (match_operand:SI 1 "register_operand" "")
   (match_operand:SI 2 "register_operand" "")
   (match_operand:SI 3 "register_operand" "")]
  "TARGET_H8300S && !TARGET_NORMAL_MODE
   && h8300_regs_ok_for_stm (4, operands)"
  "
                                                                                
It seems to me that the test for !TARGET_NORMAL_MODE in the expander's
condition does not belong and should be removed.  If you could test
that and verify the H8 port still works correctly, it would be
greatly appreciated.


jeff

Attachment: ZZZ
Description: Text document