This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: ping**4 [PATCH] stabs for powerpc Darwin target


George Helffrich +44 117 954 5437 <george@geology.bristol.ac.uk> writes:

> Could the responsible party or parties please review this patch?  (Fourth
> query).
> 
> http://gcc.gnu.org/ml/gcc-patches/2004-04/msg01719.html

Are you sure this is a GCC problem?  It seems like something that
could (and perhaps should) be fixed in GDB or the linker.

Also, for future patches:
- Please make them relative to CVS HEAD, not a release
- You have nice detailed comments, but you have put them in the ChangeLog
  instead of in the code.  Please put them in the code, and leave the ChangeLog
  just saying what was changed instead of why.
- You've added a new macro, which uses a bit in the tree structure,
  and appears to duplicate existing information.  Please use the existing
  information.

-- 
- Geoffrey Keating <geoffk@geoffk.org>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]