This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Patch: Enable tree-browser with --enable-checking
- From: Bryce McKinlay <mckinlay at redhat dot com>
- To: gcc-patches at gcc dot gnu dot org
- Date: Thu, 27 May 2004 09:45:39 -0400
- Subject: Patch: Enable tree-browser with --enable-checking
This patch removes the --enable-tree-browser configure option, and
instead enables the tree browser when --enable-checking=tree is used
(this is the default for development builds).
Rationale:
- tree-browser.o adds only a very small size overhead (approx 20k
stripped or 0.5% of cc1's total size on i686)
- its a useful debugging feature
- it sucks to have to remember yet another configure option
- it sucks to have to reconfigure gcc when you just want to
browse_tree() during a debugging session
- conceptually it isn't much different from debug_tree and other
debugging routines that are always enabled
- without enabling it by default, most developers would not build the
tree-browser code, thus it can be subject to bit-rot
OK to commit?
Bryce
2004-05-27 Bryce McKinlay <mckinlay@redhat.com>
* configure.ac: Remove --enable-tree-browser option.
Define TREEBROWSER when ac_tree_checking is defined.
* configure: Rebuilt.
Index: configure.ac
===================================================================
RCS file: /cvs/gcc/gcc/gcc/configure.ac,v
retrieving revision 2.38
diff -u -r2.38 configure.ac
--- configure.ac 25 May 2004 19:46:49 -0000 2.38
+++ configure.ac 27 May 2004 13:37:33 -0000
@@ -425,8 +425,12 @@
AC_DEFINE(ENABLE_TREE_CHECKING, 1,
[Define if you want all operations on trees (the basic data
structure of the front ends) to be checked for dynamic type safety
- at runtime. This is moderately expensive.])
+ at runtime. This is moderately expensive. The tree browser debugging
+ routines will also be enabled by this option.
+ ])
+ TREEBROWSER=tree-browser.o
fi
+AC_SUBST(TREEBROWSER)
if test x$ac_rtl_checking != x ; then
AC_DEFINE(ENABLE_RTL_CHECKING, 1,
[Define if you want all operations on RTL (the basic data structure
@@ -543,14 +547,6 @@
[Define to enable detailed memory allocation stats gathering.])
fi
-AC_ARG_ENABLE(tree-browser,
-[ --enable-tree-browser enable the tree browsing routines for debugging], [],
-[enable_tree_browser=no])
-if test x$enable_tree_browser = xyes ; then
- TREEBROWSER=tree-browser.o
-fi
-AC_SUBST(TREEBROWSER)
-
# -------------------------------
# Miscenalleous configure options
# -------------------------------