This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch to implement %` %' %q diagnostic formats
- From: Gabriel Dos Reis <gdr at integrable-solutions dot net>
- To: "Joseph S. Myers" <jsm at polyomino dot org dot uk>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 24 May 2004 18:38:05 +0200
- Subject: Re: Patch to implement %` %' %q diagnostic formats
- Organization: Integrable Solutions
- References: <Pine.LNX.4.58.0405241656480.31473@digraph.polyomino.org.uk>
"Joseph S. Myers" <jsm@polyomino.org.uk> writes:
| This patch implements the %q %` %' diagnostic formats as proposed at
| <http://gcc.gnu.org/ml/gcc-bugs/2004-03/msg00302.html>. By way of
| example it converts c-format.c to use the new formats (though more
| work is needed there to cover the places where `...' is used in
| strings that are not format strings). If approved I'll convert the C
| front end to these formats and conversions of other parts of the
| compiler will be welcome.
|
| Bootstrapped with no regressions on i686-pc-linux-gnu. OK to commit?
Yes. Thanks for implementing this.
I believe the %` %' notation -- while it did not look pretty to me in
the first place, demands less complication that plain `'. It makes
the formatting logic straight.
[...]
| 2004-05-24 Joseph S. Myers <jsm@polyomino.org.uk>
|
| * intl.h (open_quote, close_quote): New.
| * intl.c (open_quote, close_quote): New.
A question: Does this mean that we build intl even when --disable-nls?
Or is that already required before your patch?
-- Gaby