This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Search standard subdirs of -B-specified directories(take 2)


Daniel Jacobowitz <drow@false.org> writes:

> On Sat, May 22, 2004 at 03:08:34PM +0200, Paolo Bonzini wrote:
>> + 		add_prefix (&exec_prefixes, concat (value, "libexec/gcc/", NULL),
>> + 			    NULL, PREFIX_PRIORITY_B_OPT, 1, &warn_B, 0);
>>   		add_prefix (&startfile_prefixes, value, NULL,
>>   			    PREFIX_PRIORITY_B_OPT, 0, &warn_B, 0);
>> ! 		add_prefix (&startfile_prefixes, concat (value, "lib/gcc/", NULL),
>> ! 			    NULL, PREFIX_PRIORITY_B_OPT, 1, &warn_B, 0);
>> ! 		add_prefix (&include_prefixes, value, NULL,
>> ! 			    PREFIX_PRIORITY_B_OPT, 0, NULL, 0);
>> ! 		add_prefix (&include_prefixes, concat (value, "lib/gcc/", NULL),
>> ! 			    NULL, PREFIX_PRIORITY_B_OPT, 1, NULL, 0);
>>   		n_switches++;
>>   	      }
>>   	      break;
>
> In addition to Zack's comments, I'm strongly opposed to any patch that
> hardcodes the strings "lib" and "libexec" in the source!

I agree - especially since on platforms with lib64, e.g. AMD64, we
configure with --libdir=/usr/lib64, so that the directory is
/usr/lib64/gcc/...

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]