This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Refactor expansion of -D and -I specs
- From: Zack Weinberg <zack at codesourcery dot com>
- To: Paolo Bonzini <bonzini at gnu dot org>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 22 May 2004 10:28:16 -0700
- Subject: Re: [PATCH] Refactor expansion of -D and -I specs
- References: <40AF5008.email@example.com>
Paolo Bonzini <firstname.lastname@example.org> writes:
> This patch is the first of two patches to support top-level
> bootstrap in the GCC driver. This one has no behavioral
> change, it only refactors gcc.c so that the same routine
> used to output multilib paths is used to output include
> paths. The suffix used (like for example "nof" or "le"
> in ppc multilibs) is "include", so the include_prefixes
> will not end with "include" anymore.
> This part also includes the removal and poisoning of
> I also attach a sdiff between the old code for do_spec_1 and
> the new do_spec_path routine, with the whitespace a bit
> tweaked in the hope of aiding the review of the patch.
> You can see that multilib_dir becomes dir_for_machine_suffix,
> and multi_dir become dir_for_no_suffix.
> Bootstrapped/regtested i686-pc-linux-gnu, ok for mainline?
> 2004-04-30 Paolo Bonzini <email@example.com>
> * gcc.c (struct prefix_list): Add forward declaration.
> (do_spec_path): New function, extracted from...
> (do_spec_1) <'D'>: ... here. Drop support for
> (do_spec_1) <'I'>: Use do_spec_path.
> (process_command): Do not store the 'include' suffix
> in include_prefixes.
> * system.h: Poison SPACE_AFTER_L_OPTION.
This is OK.