This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: powerpc testsuite regressions
- From: Zack Weinberg <zack at codesourcery dot com>
- To: Andrew Pinski <pinskia at physics dot uc dot edu>
- Cc: Diego Novillo <dnovillo at redhat dot com>, Jeff Law <law at redhat dot com>, DevangPatel <dpatel at apple dot com>, Steven Bosscher <stevenb at suse dot de>, "gcc-patches at gcc dot gnu dot org Patches" <gcc-patches at gcc dot gnu dot org>, GCC List<gcc at gcc dot gnu dot org>, Mike Stump <mrs at apple dot com>
- Date: Thu, 20 May 2004 09:13:12 -0700
- Subject: Re: powerpc testsuite regressions
- References: <200405191635.i4JGZ3ZV029052@speedy.slc.redhat.com><1085058926.23047.10.camel@localhost.localdomain><EA6797E4-AA76-11D8-A4A1-000393A6D2F2@physics.uc.edu>
Andrew Pinski <pinskia@physics.uc.edu> writes:
>> /tmp/ccSbclDE.o(.text+0x38): In function `foo':
>> : undefined reference to `bar'
>> collect2: ld returned 1 exit status
>> compiler exited with status 1
>
>
> I think I know what is going on and how to fix it.
>
> cgraph_mark_needed_node used to be called from mark_referenced which
> made the function be in the output queue. Now
> cgraph_mark_needed_node is not called when assembling the name
> (unlike most targets which call output_addr_const rs6000 does not).
>
> OK? Bootstrapped on powerpc-apple-darwin with no regressions.
That's the right short-term fix. Long term we want cgraph to know
everything that's happening up front.
zw