This is the mail archive of the
mailing list for the GCC project.
Re: Add missing dependency to gcc/c-common.h
- From: Zack Weinberg <zack at codesourcery dot com>
- To: "Mark G. Adams" <mark dot g dot adams at sympatico dot ca>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 19 May 2004 13:32:27 -0700
- Subject: Re: Add missing dependency to gcc/c-common.h
- References: <1084990533.1476.74.camel@penguin>
"Mark G. Adams" <firstname.lastname@example.org> writes:
> gcc/c-common.h has an implicit dependency on gcc/tree.h which this patch
> makes explicit.
> Bootstrapped and tested on i686-linux with no new regressions.
> 2004-05-19 Mark G. Adams <email@example.com>
> * c-common.h: Include tree.h
> * Makefile.in: Add dependency on TREE_H to C_COMMON_H
I'm of two minds about this change. It is correct, in the sense that
c-common.h certainly does make reference to lots of things from
tree.h. However, I cannot decide whether it is appropriate to be
doing this for tree.h or rtl.h (which are included by almost all GCC
source files anyway). Also, I am not exactly enthused about
*expanding* the set of files with a direct dependency on tree.h.