This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Broken script in gcc/Makefile.in


On Wed, May 19, 2004 at 05:25:40PM +0100, Paul Brook wrote:
> The makefile segments for {AR,RANLIB,NM}_FOR_TARGET in gcc/Makefile.in are 
> broken. They contain the line
> 
>  t='$(program_transform_name)'; echo nm | sed -e $$t ;
> 
> which expands to t='s,^,arm-none-elf-,;'; echo ar | sed -e  ;
> 
> This code is only executed when running make inside gcc/ as AR_FOR_TARGET is 
> overridden by the toplevel makefile.
> 
> The patch below fixes this by avoiding the use of t.
> 
> Tested with cross from i686-linux to arm-none-elf.
> Ok?

I'm feeling dense today.  How does the one expand to the other?  It
should expand to: t='s,^,arm-none-elf-,;'; echo ar | sed -e $t ;

(Though I think the new form is nicer anyway.)

-- 
Daniel Jacobowitz


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]