This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH (mainline & 3.4-branch): Address bootstrap issues


On Thu, May 06, 2004 at 11:09:03PM -0500, Loren James Rittle wrote:
> As committed to address bootstrap issues (this should allow the
> ssa-tree auto-testers on alpha-*-freebsd5 and sparc64-*-freebsd5 to
> kick in again).  Form tested on alpha before commit.
> 
> 	* config/alpha/freebsd.h (SUBTARGET_EXTRA_SPECS): Pass -Werror.
> 	* config/arm/freebsd.h: Likewise.
> 	* config/ia64/freebsd.h: Likewise.
> 	* config/sparc/freebsd.h: Likewise.

It's standard to record what was changed, not why.  I read "pass
-Werror" and wondered why you were adding -Werror to anything at this
stage :)

This should probably be something like:
	* config/alpha/freebsd.h (SUBTARGET_EXTRA_SPECS): Undefine
	before redefinition.

> 
> Index: gcc/config/alpha/freebsd.h
> ===================================================================
> RCS file: /cvs/gcc/gcc/gcc/config/alpha/freebsd.h,v
> retrieving revision 1.12.2.6
> diff -c -r1.12.2.6 freebsd.h
> *** gcc/config/alpha/freebsd.h	26 Mar 2004 16:23:03 -0000	1.12.2.6
> --- gcc/config/alpha/freebsd.h	7 May 2004 03:26:49 -0000
> ***************
> *** 20,25 ****
> --- 20,26 ----
>   Boston, MA 02111-1307, USA.  */
>   
>   
> + #undef  SUBTARGET_EXTRA_SPECS
>   #define SUBTARGET_EXTRA_SPECS \
>     { "fbsd_dynamic_linker", FBSD_DYNAMIC_LINKER }
>   
> Index: gcc/config/arm/freebsd.h
> ===================================================================
> RCS file: /cvs/gcc/gcc/gcc/config/arm/freebsd.h,v
> retrieving revision 1.2.2.4
> diff -c -r1.2.2.4 freebsd.h
> *** gcc/config/arm/freebsd.h	26 Mar 2004 16:23:07 -0000	1.2.2.4
> --- gcc/config/arm/freebsd.h	7 May 2004 03:26:49 -0000
> ***************
> *** 20,25 ****
> --- 20,26 ----
>      Boston, MA 02111-1307, USA.  */
>   
>   
> + #undef  SUBTARGET_EXTRA_SPECS
>   #define SUBTARGET_EXTRA_SPECS \
>     { "fbsd_dynamic_linker", FBSD_DYNAMIC_LINKER }
>   
> Index: gcc/config/ia64/freebsd.h
> ===================================================================
> RCS file: /cvs/gcc/gcc/gcc/config/ia64/freebsd.h,v
> retrieving revision 1.5.2.4
> diff -c -r1.5.2.4 freebsd.h
> *** gcc/config/ia64/freebsd.h	26 Mar 2004 16:23:19 -0000	1.5.2.4
> --- gcc/config/ia64/freebsd.h	7 May 2004 03:26:49 -0000
> ***************
> *** 18,23 ****
> --- 18,24 ----
>   along with GCC; see the file COPYING.  If not, write to
>   the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA.  */
>   
> + #undef  SUBTARGET_EXTRA_SPECS
>   #define SUBTARGET_EXTRA_SPECS \
>     { "fbsd_dynamic_linker", FBSD_DYNAMIC_LINKER }
>   
> Index: gcc/config/sparc/freebsd.h
> ===================================================================
> RCS file: /cvs/gcc/gcc/gcc/config/sparc/freebsd.h,v
> retrieving revision 1.11.2.10
> diff -c -r1.11.2.10 freebsd.h
> *** gcc/config/sparc/freebsd.h	26 Mar 2004 16:23:48 -0000	1.11.2.10
> --- gcc/config/sparc/freebsd.h	7 May 2004 03:26:49 -0000
> ***************
> *** 19,24 ****
> --- 19,25 ----
>   the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA.  */
>   
>   
> + #undef  SUBTARGET_EXTRA_SPECS
>   #define SUBTARGET_EXTRA_SPECS \
>     { "fbsd_dynamic_linker", FBSD_DYNAMIC_LINKER }
>   
> 

-- 
Daniel Jacobowitz


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]