This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Use ColdFire V4 mov3q instruction to store constants to memory


>>   #define EXTRA_CONSTRAINT(OP,CODE)			\
>> +   ((((CODE) == 'R') && TARGET_CFV4)			\
>> +    ? (GET_CODE (OP) == CONST_INT			\
>> +       && (INTVAL (OP) == -1				\
>> +           || (INTVAL (OP) >= 1 && INTVAL (OP) <= 7)))	\
>> +    :							\
>>     (((CODE) == 'S')					\
>>      ? (TARGET_PCREL					\
>>         && GET_CODE (OP) == MEM				\
>
>I think it's clearer when each CODE is handled at the outer level
>without additional conditions.  That is:
>    ((((CODE) == 'R')
>       ? (TARGET_CFV4 && GET_CODE (OP) == CONST_INT

Ok. Should I resubmit the patch with this change?

-- 
Peter Barada
peter@the-baradas.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]