This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: PR target/15290: __float128 failed to pass to functionproperly
"H. J. Lu" <hjl@lucon.org> writes:
> On Wed, May 05, 2004 at 11:24:30AM -0700, Zack Weinberg wrote:
>> "H. J. Lu" <hjl@lucon.org> writes:
>>
>> > The problem
>>
>> Uh, what problem? I presume you mean the bug report referenced in the
>> subject, but it is very helpful when reviewing patches if you
>> summarize the bug.
>>
>> ...
>> > - REAL_VALUE_TO_TARGET_LONG_DOUBLE (r, l);
>> > + if (mode == TFmode)
>> > + REAL_VALUE_TO_TARGET_QUAD_DOUBLE (r, l);
>> > + else
>> > + REAL_VALUE_TO_TARGET_LONG_DOUBLE (r, l);
>>
>> Better just
>>
>> - REAL_VALUE_TO_TARGET_LONG_DOUBLE (r, l);
>> + real_to_target (l, &r, mode);
>>
>> and then you don't need to introduce yet another macro.
>>
>
> If we want to use this approach, why not remove the whole
> REAL_VALUE_TO_TARGET_XXX?
I would like to see that happen, yes, but that's tangential to fixing
the bug.
zw