This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA:] Fix PR optimization/15296, delayed-branch-slot bug.


> From: law@redhat.com
> Date: Wed, 05 May 2004 10:20:46 -0600

Thanks for the extremely quick review!

> I agree that reorg needs to be rewritten and I strongly feel any rewrite
> ought be centered around building a real data dependency graph (or re-using
> one from a previous pass such as sched2).  Given a real data dependency graph,
> most of the stuff reorg does becomes simpler and faster (consider something
> like 20001226-1.c on most delay slot targets).

Yeah, you've mentioned that once or twice. ;-)
(I have this futile hope that I'll get to fix it some time.
Maybe it'll actually happen this year.)

> The testcase at least at first glance looks like it may not work for our
> 16bit targets....  You might want to restrict it to working on 32/64 bit
> targets.

Something in particular that looks nonworking?  I believe the
assumption that "void *" is assignment-compatible with
"int __attribute__ ((mode (__pointer__)))" is safe, but is that all?
I've started a h8300-elf run to see if it fails there.
Is that a sufficient test for approval?

brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]