This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]


On Mon, 2004-05-03 at 17:40, Ulrich Weigand wrote:
> Eric Christoper wrote:
> 
> >Having lots of problems with the tpf tracing functions until it was
> >realized that they don't actually affect anything and don't need
> >standard call mechanisms for save and restore either, just execute.
> 
> How come?  Your change shouldn't generate any different code;
> could you elaborate what the problems were?

Regrename wanted to start changing things around and inside the branch
and then flow would complain about register liveness later. Optimization
would also play havoc with varargs. I can send you a couple of testcases
if you'd like...

> 
> >+(define_insn "prologue_tpf"
> >+  [(unspec_volatile [(const_int 0)] UNSPECV_TPF_PROLOGUE)]
> >+  "TARGET_TPF"
> >+  "bas\t%%r1,4064"
> >+  [(set_attr "type" "jsr")])
> 
> We should have a (clobber (reg 1)) here at least ...

I thought that it wouldn't be guaranteed to have anything there going in
here, but I can add the clobber.

-eric

-- 
Eric Christopher <echristo@redhat.com>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]