This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Add -iquote support


Mike Stump <mrs@apple.com> writes:

> On Monday, May 3, 2004, at 03:28 PM, Zack Weinberg wrote:
>> Sorry.  I insist that these be coupled.  We will not have both.
>
> Ok, here's the patch...
>
> Ok?

A few changes needed:

1) You removed the processing of -I- entirely.  Better it should
   produce an error.  (Which means that you need to leave the note
   about using -I./- if you really mean search a directory named "-"
   in the documentation.)

2) The comment at the head of remove_duplicates, explaining why we
   can't merge the lists and then uniquize them, shouldn't be removed;
   it's still true.  Just change the notation.

3) You removed the logic that sets quote_ignores_source_dir but you
   did not remove the logic that uses it, which is now dead; please do so.

4) This requires an entry in the "Differences from previous versions"
   section of the CPP manual, and an entry in the 3.5 release notes;
   and, as I said, a loud public announcement (suggest posting to
   gcc-announce).

5) Why are you messing with g77?  I understand that it has similar
   functionality, but that entire directory is (as I understand it)
   getting deleted when tree-ssa merges, which is probably sometime
   this week.  And I don't see much reason to provide all of C's hairy
   preprocessor switches for Fortran, anyway.

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]