This is the mail archive of the
mailing list for the GCC project.
Re: [patch] gcc: Fix comment typos.
- From: Roger Sayle <roger at eyesopen dot com>
- To: Hans-Peter Nilsson <hp at bitrange dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Kazu Hirata <kazu at cs dot umass dot edu>
- Date: Sat, 1 May 2004 10:19:13 -0600 (MDT)
- Subject: Re: [patch] gcc: Fix comment typos.
On Sat, 1 May 2004, Hans-Peter Nilsson wrote:
> > +++ config/cris/cris.h 30 Apr 2004 16:07:44 -0000
> > @@ -337,7 +337,7 @@
> > /* Whether or not to work around multiplication instruction hardware bug
> > when generating code for models where it may be present. From the
> > trouble report for Etrax 100 LX: "A multiply operation may cause
> > - incorrect cache behaviour under some specific circumstances. The
> > + incorrect cache behavior under some specific circumstances. The
> You're "fixing typos" (actually adjusting spelling, from BE to
> AE) in a *quote*. Quotes should be left the way they are, or
> else they stop being quotes.
Just my personal opinion, and I apologise if this has been discussed
and agreed upon previously, but I think this is an overly "strict"
definition of a quote. "I came, I saw, I conquered" is still a quote
even though Julius Caesar pronounced it differently.
Personally, I find it far more convenient that when a contributor quotes
from a non-English (e.g. Japanese) technical report or user manual that
they make the effort to translate this into English. Not only does this
avoid problems with character sets, and avoid the number of languages
required by both native and non-native english speakers but it also
simplifies the task of identifying real typos in GCC's source code.
To "quote" the X11 project's onecko.c source code :>
int WindowWidth; /* @%k!<%H%&%#%s%I%&$NI}J */
int WindowHeight; /* @%k!<%H%&%#%s%I%&$N9b$5J */
XColor theForegroundColor; /* @?'J (@%U%)%"%0%i%&%s%IJ) */
XColor theBackgroundColor; /* @?'J (@%P%C%/%0%i%&%s%IJ) */