This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC PATCH]: are we using FIX_*_EXPR ?


On Fri, 30 Apr 2004, Kaveh R. Ghazi wrote:
> Some questions:
>
> 1.  I noticed in tree.def we have FIX_TRUNC_EXPR, FIX_CEIL_EXPR,
>     FIX_FLOOR_EXPR and FIX_ROUND_EXPR, but we don't seem to actually
>     build them anywhere.  Are they used at all?
>
> 2.  Second, in looking at where we use them I noticed we usually
>     either handle all four or we handle just FIX_TRUNC_EXPR.  But in
>     two cases where we handled more than one, we were missing
>     FIX_ROUND_EXPR.

Thanks for reminding me.  I discussed these issues with RTH back in
January in http://gcc.gnu.org/ml/gcc-patches/2004-01/msg01985.html
In that post I agreed to write real_round (and did so) but I obviously
must have completely forgotten to use it to implement FIX_ROUND_EXPR.


> 2004-04-30  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>
>
> 	* fold-const.c (fold_convert_const, fold): Add missing
> 	FIX_ROUND_EXPR case.
>

This is OK for mainline.

Of course, I still owe the c-tree.texi documentation describing the
FIX_FLOOR_EXPR, FIX_CEIL_EXPR and FIX_ROUND_EXPR tree nodes :{

Thanks,

Roger
--


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]