This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [tree-ssa] PATCH to ease fileline/location_t merge
Per Bothner <per@bothner.com> writes:
> Zack Weinberg wrote:
>
>> Per Bothner <per@bothner.com> writes:
>>
>>>+#ifdef USE_MAPPED_LOCATION
>>>+#define EXPR_LOCATION(NODE) \
>>>+ (IS_EXPR_CODE_CLASS (TREE_CODE_CLASS (TREE_CODE (NODE))) \
>>>+ ? (NODE)->exp.locus \
>>>+ : UNKNOWN_LOCATION)
>> Why is this not a tree-checking ICE if !IS_EXPR_CODE_CLASS (...) ?
>
> I don't know - ask the people who wrote the EXPR_LOCUS code,
> which makes the same test.
Since it's inherited, I have no objection to leaving as is, but would
recommend that you try changing it to an ICE as a separate patch and
see what breaks.
zw