This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: update_path should match only on entire directory names


On Apr 20, 2004, at 09:51, Thomas Quinot wrote: 
!   if (! strncmp (path, std_prefix, len)
!       && (path[len] == '/'
! #ifdef DIR_SEPARATOR
!           || path[len] == DIR_SEPARATOR
! #endif
!           || path[len] == '\0')
!       && key != 0)


I'd think you should be using IS_DIR_SEPARATOR instead. I
notice \ that your patch is relative to GCC 3.2.3, but this
branch is  long dead and most likely you'd want submit a patch
for  mainline GCC. Also, don't forget to include a properly
formatted ChangeLog entry and a note on the testing you did.

-Geert

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]