This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Fix PR middle-end/6123, cleanup defining __pic__/__PIC__


> 4.  In rs6000/linux64.h, it hardcodes just __PIC__=1.
> 
> However for #4 on powerpc64-unknown-linux-gnu, the default case does
> not define __PIC__ with my patch, so this is a change.  I'm not sure
> why powerpc64 wants only __PIC__ hardcoded but not __pic__ and why
> it's different from regular powerpc.  Perhaps there's something wrong
> here. (?)

	PPC64 Linux always is PIC, so this patch is wrong.

	If targets have well-establish meanings for __pic__ and __PIC__,
GCC cannot impose it's own definition.  This patch changes the behavior
for multiple targets.

	I object to this patch.

David


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]