This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix the last known bootstrap problem on PPC Darwin (PR target/14580)



On Mar 21, 2004, at 09:51, James Morrison wrote:


Index: rs6000.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/rs6000/rs6000.c,v
retrieving revision 1.613
diff -u -p -r1.613 rs6000.c
--- rs6000.c	20 Mar 2004 02:56:52 -0000	1.613
+++ rs6000.c	21 Mar 2004 17:46:38 -0000
@@ -2260,6 +2260,23 @@ symbol_ref_operand (rtx op, enum machine
   if (mode != VOIDmode && GET_MODE (op) != mode)
     return 0;

+  if (GET_CODE (op) == SYMBOL_REF)
+    {
+      if (TARGET_MACHO)
+        {
+          /* Macho says it has to go through a stub or be local
+             when indirect mode.  Stubs are considered local.  */
+#if TARGET_MACHO

Why are you testing for TARGET_MACHO twice?


+	  if (MACHOPIC_INDIRECT)
+	    {

Well the preprocessor check is because MACHOPIC_INDIRECT is only defined
when darwin.h is included which is only when TARGET_MACHO is true, the
other one was because it was standard practice to use the normal if, and
I added the check for MACHOPIC_INDIRECT as an after thought but tested that
way.



Thanks, Andrew Pinski


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]