This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Summary of patches


On Fri, Mar 05, 2004 at 12:34:15PM +0100, Jan Hubicka wrote:
> *************** init_function_for_compilation (void)
> *** 6524,6532 ****
>     reg_renumber = 0;
>   
>     /* No prologue/epilogue insns yet.  */
> !   VARRAY_GROW (prologue, 0);
> !   VARRAY_GROW (epilogue, 0);
> !   VARRAY_GROW (sibcall_epilogue, 0);
>   }
>   
>   /* Expand a call to __main at the beginning of a possible main function.  */
> --- 6526,6540 ----
>     reg_renumber = 0;
>   
>     /* No prologue/epilogue insns yet.  */
> !   if (prologue)
> !     VARRAY_FREE (prologue);
> !   if (epilogue)
> !     VARRAY_FREE (epilogue);
> !   if (sibcall_epilogue)
> !     VARRAY_FREE (sibcall_epilogue);

Seems to me this freeing should be done at the end of function compilation

> !   VARRAY_INT_INIT (prologue, 0, "prologue");
> !   VARRAY_INT_INIT (epilogue, 0, "epilogue");
> !   VARRAY_INT_INIT (sibcall_epilogue, 0, "sibcall_epilogue");

And this done when we actually start generating prologues.


The rest of the patch is ok though.



r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]