This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Compat testsuite improvement (part #1)


On Mon, Mar 15, 2004 at 05:11:43PM -0800, Zack Weinberg wrote:
> Janis Johnson <janis187@us.ibm.com> writes:
>
> > I'm also planning to fix the complex constant values used in these tests
> > so they don't use the Fortran syntax which is a comma expression in C.
> 
> Cool.
> 
> It would be more work, but would you consider changing all these tests
> to get their numbers from statically initialized arrays, rather than
> lists of globals with runtime-calculated values, and to check the
> values by straight comparison with these arrays?  Runtime computation
> introduces another source of error - I've several times now had the
> compat testsuite find bugs that had nothing to do with the ABI.  Which
> is all very well, but causes no end of headache to the poor schmuck
> trying to figure out what's wrong with the argument passing (because
> there isn't anything wrong with the argument passing).

Sure, I'd like these to be easier to use so I'll take a look at that.

Janis


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]