This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Use C90-style function pointer calls in fold-const.c


Roger Sayle <roger@eyesopen.com> writes:

> The following patch updates calls of the form "(*lang_hooks.foo) (...)"
> in fold-const.c to use what I believe is the now preferred C90 style,
> "lang_hooks.foo (...)".
>
> Regrettably, I'm not 100% confident that this idiom is the GCC preference,
> virtually all uses of lang_hooks in GCC currently use the (*lang_hooks)
> form, so I thought I'd ask for a second opinion, even though C90 clean-ups
> have been pre-approved.  Apologies for showing my ignorance.

I recall it was agreed that all calls to function pointers should be
converted to the C90 implicit-dereference syntax.  As such, I say this
patch is OK, and I say all other patches which just remove explicit (* )
from calls through function pointers are also OK.

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]